Saved searches

Use saved searches to filter your results more quickly

You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session. You switched accounts on another tab or window. Reload to refresh your session.

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce a reqtorio valhalla vendor #16428

Introduce a reqtorio valhalla vendor #16428

Conversation

This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters

About The Pull Request

Brings all the factorio goodness in a compact, hopefully well organized package, in the form of a valhalla vendor. Currently has every factorio machines, the factorio paper guide, conveyor belts and the switch to go with it. Every refill available to req has is available with the only exception being drop pods as I suspect it could be used to deploy valhalla characters on the map. I am not sure. But if it's safe to do so I might add it.

Why It's Good For The Game

It would allow req enthustiasts to experiment with factory designs in valhalla, check recipes, improve productivity, learn about the intricacies of production, so on and so forth.

Changelog

🆑 Koenigsegg
add: Added a valhalla reqtorio vendor
add: Added the reqtorio valhalla vendor to the vehicle pit in valhalla
/:cl:

Introduce a factorio valhalla vendor that contains all but one req refills (the one exception being drop pod as I believe that could be used to deploy on the map). For the purpose of trying out factorio designs. All placed one vendor in the westernmost part of the valhalla as I could not figure where to make a proper factorio room yet.

tgstation-server added Map Edit One or more changes to .dmm files. Feature New interesting mechanics with new interesting bugs labels Aug 2, 2024

factorio brainrot, fixing the typo real quick

This will probably skew round end stats, not that it matters but yeah

This will probably skew round end stats, not that it matters but yeah

I didn't think about that huh. Sadly my understanding of the dm language is relatively limited so I'm not too sure how I'd go about writing an exception for end of round stats. I could look into it though and attempt to decipher the dark magic behind it.

This will probably skew round end stats, not that it matters but yeah

I didn't think about that huh. Sadly my understanding of the dm language is relatively limited so I'm not too sure how I'd go about writing an exception for end of round stats. I could look into it though and attempt to decipher the dark magic behind it.

Round End Stats just take a variable and add +1. You could find where the variable gets incremented for the stats relevant to this PR. And then, add a check. If this is located in Valhalla, or if this is an item flagged as being a Valhalla spawned thing, don't increment it.

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be scared of people building this at highpop but we'll delete this if it becomes na issue i guess

Also yea tweaking the stat to check for if its on the admin z would be good

I looked into it, might have the part of the code that registers specific stuff to display them at round end but really that is beyond what I am capable of, it might be more trouble than it is worth. I can understand code that add lists, items, and such, but the rest is unknown territory.

This comment was marked as off-topic.

I looked into it, might have the part of the code that registers specific stuff to display them at round end but really that is beyond what I am capable of, it might be more trouble than it is worth. I can understand code that add lists, items, and such, but the rest is unknown territory.

you should check if is_gameplay_level is true

is called it shouldnt be that hard lmk if you need help

Feature New interesting mechanics with new interesting bugs Map Edit One or more changes to .dmm files.

Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.